Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fb119935e11b98230f20c500e9f9125ddf0f3a4d
Commit:     fb119935e11b98230f20c500e9f9125ddf0f3a4d
Parent:     deff2627cda995c926788fd9192337ec3febe7b5
Author:     Eric Sesterhenn <[EMAIL PROTECTED]>
AuthorDate: Wed May 23 14:41:36 2007 -0700
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Mon May 28 09:08:32 2007 -0500

    [SCSI] sg: remove unnecessary check
    
    coverity spotted this (cid #758).  All callers dereference sfp, so we dont
    need this check.  In addition to this, we dereference it earlier in the
    function.
    
    Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]>
    Acked-by: Douglas Gilbert <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
---
 drivers/scsi/sg.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 0c691a6..85d3894 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1842,7 +1842,7 @@ sg_build_indirect(Sg_scatter_hold * schp, Sg_fd * sfp, 
int buff_size)
        int blk_size = buff_size;
        struct page *p = NULL;
 
-       if ((blk_size < 0) || (!sfp))
+       if (blk_size < 0)
                return -EFAULT;
        if (0 == blk_size)
                ++blk_size;     /* don't know why */
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to