Commit:     5ebf6e6a96e41220edec23a90e4140985d1a5732
Parent:     3be86148e7b394b5de2aeb720004f9788a66c300
Author:     Jeff Garzik <[EMAIL PROTECTED]>
AuthorDate: Sat Jul 14 19:12:04 2007 -0400
Committer:  Anton Vorontsov <[EMAIL PROTECTED]>
CommitDate: Sun Jul 15 22:32:03 2007 +0400

    pda_power: clean up irq, timer
    Clean up pda_power interrupt handling:
    Prior to this patch, the driver would pass information it needed
    to the interrupt handler dev_id pointer, and then prompt forget it
    ever did so, recreating that same information after a couple passes
    through the timer-based state machine.
    This patch removes the redundant checks by passing the
    pda_power_supply[] pointer through the state machine.  The current
    code passed 'irq' through the state machine, as an index to recreate
    the pointer, when we could more simply pass around the pointer itself.
    This patch makes it easier to remove the 'irq' argument in the future,
    in addition to cleaning up the driver today.
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
 drivers/power/pda_power.c |   17 ++++++++---------
 1 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
index 4e1eb04..cdc2892 100644
--- a/drivers/power/pda_power.c
+++ b/drivers/power/pda_power.c
@@ -101,32 +101,31 @@ static void update_charger(void)
-static void supply_timer_func(unsigned long irq)
+static void supply_timer_func(unsigned long power_supply_ptr)
-       if (ac_irq && irq == ac_irq->start)
-               power_supply_changed(&pda_power_supplies[0]);
-       else if (usb_irq && irq == usb_irq->start)
-               power_supply_changed(&pda_power_supplies[1]);
+       void *power_supply = (void *)power_supply_ptr;
+       power_supply_changed(power_supply);
-static void charger_timer_func(unsigned long irq)
+static void charger_timer_func(unsigned long power_supply_ptr)
        /* Okay, charger set. Now wait a bit before notifying supplicants,
         * charge power should stabilize. */
- = irq;
+ = power_supply_ptr;
                  jiffies + msecs_to_jiffies(pdata->wait_for_charger));
-static irqreturn_t power_changed_isr(int irq, void *unused)
+static irqreturn_t power_changed_isr(int irq, void *power_supply)
        /* Wait a bit before reading ac/usb line status and setting charger,
         * because ac/usb status readings may lag from irq. */
- = irq;
+ = (unsigned long)power_supply;
                  jiffies + msecs_to_jiffies(pdata->wait_for_status));
        return IRQ_HANDLED;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to