Commit:     2a41de48b81e61fbe260ae5031ebcb6f935f35fb
Parent:     13c22168b7276dffe49dc66675d5a78f6d288e0d
Author:     Alexey Dobriyan <[EMAIL PROTECTED]>
AuthorDate: Tue Jul 17 04:03:56 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Tue Jul 17 10:23:03 2007 -0700

    Fix sparse false positives re BUG_ON(ptr)
    sparse now warns if one compares pointers with integers. However, there are
    false positives, like:
        fs/filesystems.c:72:2: warning: Using plain integer as NULL pointer
    Every time BUG_ON(ptr) is used, ptr is checked against integer zero.  Avoid
    that and save ~70 false positives from allyesconfig run.
    mentioned by Al.
    Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
    Acked-by: Al Viro <[EMAIL PROTECTED]>
    Acked-by: Josh Triplett <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 include/asm-generic/bug.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 7f30cce..344e309 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -28,7 +28,7 @@ struct bug_entry {
-#define BUG_ON(condition) do { if (unlikely((condition)!=0)) BUG(); } while(0)
+#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while(0)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to