Commit:     5e6c20a93b700ba884a6bced498b2691e2dd821b
Parent:     8cd2aba2d3fc065069a0c305ddca1d9397ed9092
Author:     Andrew Morton <[EMAIL PROTECTED]>
AuthorDate: Tue Jul 17 04:04:22 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Tue Jul 17 10:23:06 2007 -0700

    isdn/capi warning fixes
    drivers/isdn/capi/capi.c: In function 'handle_minor_send':
    drivers/isdn/capi/capi.c:552: warning: cast from pointer to integer of 
different size
    Of course, the code here might actually be buggy, in which case this patch
    should not be applied?
      No this field is ignored inside linux kernel.Yes this is ugly, but it's
      the CAPI spec for all OS.
      CAPI DATA_B3 Request/Indication CAPI Message has a mandatory field which
      represent the 32 bit buffer address of the payload data.  In linux the
      payload data do not use a sperate buffer, data follows directely after the
      CAPI Message in the same skb and we use this assumption inside the 
      so we can ignore this field.
      Inside the linux CAPI implemetation we never use this field, so it could
      also have no value, but since random data in a message is bad as well 
      displayed in CAPI traces) we set is to the most adequate value.
      Outside the kernel the capi20 library sets the correct addresses (there is
      an optional second field for 64 bit adresses for 64 bit systems, we do not
      use here).
    Acked-by: Karsten Keil <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/isdn/capi/capi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
index 81661b8..f449dae 100644
--- a/drivers/isdn/capi/capi.c
+++ b/drivers/isdn/capi/capi.c
@@ -549,7 +549,7 @@ static int handle_minor_send(struct capiminor *mp)
                capimsg_setu8 (skb->data, 5, CAPI_REQ);
                capimsg_setu16(skb->data, 6, mp->msgid++);
                capimsg_setu32(skb->data, 8, mp->ncci); /* NCCI */
-               capimsg_setu32(skb->data, 12, (u32) skb->data); /* Data32 */
+               capimsg_setu32(skb->data, 12, (u32)(long)skb->data);/* Data32 */
                capimsg_setu16(skb->data, 16, len);     /* Data length */
                capimsg_setu16(skb->data, 18, datahandle);
                capimsg_setu16(skb->data, 20, 0);       /* Flags */
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to