Commit:     a1da4dfe35bc36c3bc9716d995c85b7983c38a76
Parent:     2ee97caf0a6602f749ddbfdb1449e383e1212707
Author:     Tejun Heo <[EMAIL PROTECTED]>
AuthorDate: Wed Jul 18 16:14:45 2007 +0900
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Wed Jul 18 15:49:50 2007 -0700

    sysfs: kill an extra put in sysfs_create_link() failure path
    There is a subtle bug in sysfs_create_link() failure path.  When
    symlink creation fails because there's already a node with the same
    name, the target sysfs_dirent is put twice - once by failure path of
    sysfs_create_link() and once more when the symlink is released.
    Fix it by making only the symlink node responsible for putting
    Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
    Cc: Gabriel C <[EMAIL PROTECTED]>
    Cc: Miles Lane <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
 fs/sysfs/symlink.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c
index 2f86e04..d056e96 100644
--- a/fs/sysfs/symlink.c
+++ b/fs/sysfs/symlink.c
@@ -86,7 +86,9 @@ int sysfs_create_link(struct kobject * kobj, struct kobject * 
target, const char
        sd = sysfs_new_dirent(name, S_IFLNK|S_IRWXUGO, SYSFS_KOBJ_LINK);
        if (!sd)
                goto out_put;
        sd->s_elem.symlink.target_sd = target_sd;
+       target_sd = NULL;       /* reference is now owned by the symlink */
        sysfs_addrm_start(&acxt, parent_sd);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to