Commit:     bf903d0a4503db8ac166ca6135a59bc5f9b91a45
Parent:     e5bd762bda0d9aba8739a35f898479dc12e288a1
Author:     Yasuaki Ishimatsu <[EMAIL PROTECTED]>
AuthorDate: Wed Jul 18 15:47:34 2007 +0900
Committer:  Tony Luck <[EMAIL PROTECTED]>
CommitDate: Thu Jul 19 14:03:55 2007 -0700

    [IA64] Delete iosapic_free_rte()
    >   arch/ia64/kernel/iosapic.c:597: warning: 'iosapic_free_rte' defined but 
not used
    > This isn't spurious, the only call to iosapic_free_rte() has been 
removed, but there
    > is still a call to iosapic_alloc_rte() ... which means we must have a 
memory leak.
    I did it on purpose (and gave the warning a miss...) and I consider
    iosapic_free_rte() is no longer needed.
    I decided to remain iosapic_rte_info to keep gsi-to-irq binding
    after device disable. Indeed it needs some extra memory, but it
    is only "sizeof(iosapic_rte_info) * <the number of removed devices>"
    bytes and has no memory leak becasue re-enabled devices use the
    iosapic_rte_info which they used before disabling.
    Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]>
    Signed-off-by: Tony Luck <[EMAIL PROTECTED]>
 arch/ia64/kernel/iosapic.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/arch/ia64/kernel/iosapic.c b/arch/ia64/kernel/iosapic.c
index c101c8b..91e6dc1 100644
--- a/arch/ia64/kernel/iosapic.c
+++ b/arch/ia64/kernel/iosapic.c
@@ -593,14 +593,6 @@ static struct iosapic_rte_info *iosapic_alloc_rte (void)
        return rte;
-static void iosapic_free_rte (struct iosapic_rte_info *rte)
-       if (rte->flags & RTE_PREALLOCATED)
-               list_add_tail(&rte->rte_list, &free_rte_list);
-       else
-               kfree(rte);
 static inline int irq_is_shared (int irq)
        return (iosapic_intr_info[irq].count > 1);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to