Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e840cfe6814d6f13ecb86cff7097ad7259df502e
Commit:     e840cfe6814d6f13ecb86cff7097ad7259df502e
Parent:     d054b36ffd302ec65aabec16a0c60ddd9e6b5a62
Author:     Jeremy Kerr <[EMAIL PROTECTED]>
AuthorDate: Fri Jul 20 21:39:32 2007 +0200
Committer:  Arnd Bergmann <[EMAIL PROTECTED]>
CommitDate: Fri Jul 20 21:41:49 2007 +0200

    [CELL] spufs: Remove spurious WARN_ON for spu_deactivate for NOSCHED 
contexts
    
    In 6cbf93960e64f313f6e247cbca7afaa50e3ee2c we added a WARN_ON for
    calling spu_deactivate on contexts created with the SPU_CREATE_NOSCHED
    flag. However, all NOSCHED contexts will need to be deactivated when
    the context is destroyed, so this gives a spurious warning when any
    NOSCHED context is closed.
    
    This change removes the WARN_ON.
    
    Signed-off-by: Jeremy Kerr <[EMAIL PROTECTED]>
    Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
 arch/powerpc/platforms/cell/spufs/sched.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/arch/powerpc/platforms/cell/spufs/sched.c 
b/arch/powerpc/platforms/cell/spufs/sched.c
index 9b1706c..fe78930 100644
--- a/arch/powerpc/platforms/cell/spufs/sched.c
+++ b/arch/powerpc/platforms/cell/spufs/sched.c
@@ -550,15 +550,6 @@ static int __spu_deactivate(struct spu_context *ctx, int 
force, int max_prio)
  */
 void spu_deactivate(struct spu_context *ctx)
 {
-       /*
-        * We must never reach this for a nosched context,
-        * but handle the case gracefull instead of panicing.
-        */
-       if (ctx->flags & SPU_CREATE_NOSCHED) {
-               WARN_ON(1);
-               return;
-       }
-
        __spu_deactivate(ctx, 1, MAX_PRIO);
        spuctx_switch_state(ctx, SPUCTX_UTIL_USER);
 }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to