Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=528fd55200ec135548e71aee43650bca92a041aa
Commit:     528fd55200ec135548e71aee43650bca92a041aa
Parent:     27e92471b5d8b3e70646dfaf9369d96773972efd
Author:     James Bottomley <[EMAIL PROTECTED]>
AuthorDate: Mon Oct 16 10:57:05 2006 -0500
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Wed Jul 18 11:14:25 2007 -0500

    [SCSI] libsas: better error handling in sas_ex_discover_end_dev()
    
    This replaces a few BUG_ON() statements with the correct failure error
    handling.  There are still many more to do.
    
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
---
 drivers/scsi/libsas/sas_expander.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/libsas/sas_expander.c 
b/drivers/scsi/libsas/sas_expander.c
index 0746487..d05fc23 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -670,8 +670,8 @@ static struct domain_device *sas_ex_discover_end_dev(
                       sizeof(struct dev_to_host_fis));
 
                rphy = sas_end_device_alloc(phy->port);
-               /* FIXME: error handling */
-               BUG_ON(!rphy);
+               if (unlikely(!rphy))
+                       goto out_free;
 
                sas_init_dev(child);
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to