Commit:     77926826f301fbd8ed96d3cd9ff17a5b59560dfb
Parent:     e4903fb59590f86190280a549420f6cb85bd7f7e
Author:     Paul Mackerras <[EMAIL PROTECTED]>
AuthorDate: Thu Jul 26 13:44:36 2007 +1000
Committer:  Paul Mackerras <[EMAIL PROTECTED]>
CommitDate: Thu Jul 26 13:44:36 2007 +1000

    Revert "[POWERPC] Don't complain if size-cells == 0 in prom_parse()"
    This reverts commit fd6e9d3945ee122eb513ada8b17296d243c1ce5e.
    Having #size-cells == 0 in a node indicates that things under the
    node aren't directly accessible, and therefore we shouldn't try to
    translate addresses for devices under the node into CPU physical
    Some drivers, such as the nvram driver for powermacs, rely on
    of_address_to_resource failing if they are called for a node
    representing a device whose resources aren't directly accessible
    by the CPU.  These drivers were broken by commit fd6e9d39,
    resulting in the "Lombard" powerbook hanging early in the boot
    Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]>
 arch/powerpc/kernel/prom_parse.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c
index 3786dcc..b5c96af 100644
--- a/arch/powerpc/kernel/prom_parse.c
+++ b/arch/powerpc/kernel/prom_parse.c
@@ -24,7 +24,7 @@
 /* Max address size we deal with */
 #define OF_MAX_ADDR_CELLS      4
 #define OF_CHECK_COUNTS(na, ns)        ((na) > 0 && (na) <= OF_MAX_ADDR_CELLS 
&& \
-                       (ns) >= 0)
+                       (ns) > 0)
 static struct of_bus *of_match_bus(struct device_node *np);
 static int __of_address_to_resource(struct device_node *dev,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to