Commit:     04a3f959f691fd3eea42be37bc7a8cf32c1bd899
Parent:     6a648fa72161d1f6468dabd96c5d3c0db04f598a
Author:     Helge Deller <[EMAIL PROTECTED]>
AuthorDate: Fri Aug 10 13:00:45 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Sat Aug 11 15:47:40 2007 -0700

    stifb: detect cards in double buffer mode more reliably
    Visualize-EG, Graffiti and A4450A graphics cards on PARISC can
    be configured in double-buffer and standard mode, but the stifb
    driver supports standard mode only.
    This patch detects double-buffered cards more reliable.
    It is a real bugfix for a very nasty problem for all parisc users which have
    wrongly configured their graphic card.  The problem: The stifb graphics 
    will not detect that the card is wrongly configured and then nevertheless 
    enables the graphics mode, which it shouldn't.  In the end, the user will 
    no further updates / boot messages on the screen.
    We had documented this problem already on our FAQ
    ( "Why do I get corrupted 
    with my Vis-EG/Graffiti/A4450A card?") but people still run into this 
     So having this fix in as early as possible can help us.
    Signed-off-by: Helge Deller <[EMAIL PROTECTED]>
    Signed-off-by: Antonino Daplas <[EMAIL PROTECTED]>
    Cc: Kyle McMartin <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/video/stifb.c |   19 ++++++++++++-------
 1 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/drivers/video/stifb.c b/drivers/video/stifb.c
index c97709e..e7c8db2 100644
--- a/drivers/video/stifb.c
+++ b/drivers/video/stifb.c
@@ -1100,13 +1100,18 @@ stifb_init_fb(struct sti_struct *sti, int bpp_pref)
        /* only supported cards are allowed */
        switch (fb->id) {
        case CRT_ID_VISUALIZE_EG:
-               /* look for a double buffering device like e.g. the 
-                  "INTERNAL_EG_DX1024" in the RDI precisionbook laptop
-                  which won't work. The same device in non-double 
-                  buffering mode returns "INTERNAL_EG_X1024". */
-               if (strstr(sti->outptr.dev_name, "EG_DX")) {
-                  printk(KERN_WARNING 
-                       "stifb: ignoring '%s'. Disable double buffering in IPL 
+               /* Visualize cards can run either in "double buffer" or
+                 "standard" mode. Depending on the mode, the card reports
+                 a different device name, e.g. "INTERNAL_EG_DX1024" in double
+                 buffer mode and "INTERNAL_EG_X1024" in standard mode.
+                 Since this driver only supports standard mode, we check
+                 if the device name contains the string "DX" and tell the
+                 user how to reconfigure the card. */
+               if (strstr(sti->outptr.dev_name, "DX")) {
+                  printk(KERN_WARNING "WARNING: stifb framebuffer driver does 
not "
+                       "support '%s' in double-buffer mode.\n"
+                       KERN_WARNING "WARNING: Please disable the double-buffer 
mode "
+                       "in IPL menu (the PARISC-BIOS).\n",
                   goto out_err0;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to