Commit:     24c7387333c77b602ece7ecd6a85fc94f8f16d8c
Parent:     bdcb88562ca90e6cfac13130e147c63aaa4f9e41
Author:     Bob Peterson <[EMAIL PROTECTED]>
AuthorDate: Thu Jul 12 16:58:50 2007 -0500
Committer:  Steven Whitehouse <[EMAIL PROTECTED]>
CommitDate: Tue Aug 14 10:32:43 2007 +0100

    [GFS2] soft lockup in rgblk_search
    This patch seems to fix the problem described in bugzilla bug 246114.
    It was written by Steve Whitehouse with some tweaking by me.
    The code was looping in the relatively new section of code designed to
    search for and reuse unlinked inodes.  In cases where it was finding an
    appropriate inode to reuse, it was looping around and finding the same
    block over and over because a "<=" check should have been a "<" when
    comparing the goal block to the last unlinked block found.
    Signed-off-by: Bob Peterson <[EMAIL PROTECTED]>
    Signed-off-by: Steven Whitehouse <[EMAIL PROTECTED]>
 fs/gfs2/rgrp.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index e4e0406..bb58e69 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -863,16 +863,19 @@ static struct inode *try_rgrp_unlink(struct gfs2_rgrpd 
*rgd, u64 *last_unlinked)
        u64 no_addr;
        for(;;) {
+               if (goal >= rgd->rd_data)
+                       break;
                goal = rgblk_search(rgd, goal, GFS2_BLKST_UNLINKED,
                if (goal == 0)
-                       return 0;
+                       break;
                no_addr = goal + rgd->rd_data0;
-               if (no_addr <= *last_unlinked)
+               goal++;
+               if (no_addr < *last_unlinked)
                *last_unlinked = no_addr;
                inode = gfs2_inode_lookup(rgd->rd_sbd->sd_vfs, DT_UNKNOWN,
-                                       no_addr, -1);
+                                         no_addr, -1);
                if (!IS_ERR(inode))
                        return inode;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to