Commit:     1207cf84f289694ba7ba8eeaa346a0195b3de606
Parent:     e48eb085aca2971a1249efbb68f33e9ebca1395e
Author:     Jesper Juhl <[EMAIL PROTECTED]>
AuthorDate: Thu Aug 9 23:02:36 2007 +0200
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Wed Aug 22 14:27:47 2007 -0700

    USB: Fix a memory leak in em28xx_usb_probe()
    If, in em28xx_usb_probe() the memory allocation
        dev->alt_max_pkt_size = kmalloc(32*
    fails, then we'll bail out and return -ENOMEM.
    The problem is that in that case we don't free the storage allocated
    to 'dev', thus causing a memory leak.
    This patch fixes the leak by freeing 'dev' before we return -ENOMEM.
    This fixes Coverity bug #647.
    Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
 drivers/media/video/em28xx/em28xx-video.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/em28xx/em28xx-video.c 
index 2c7b158..40307f3 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -1772,6 +1772,7 @@ static int em28xx_usb_probe(struct usb_interface 
        if (dev->alt_max_pkt_size == NULL) {
                em28xx_errdev("out of memory!\n");
+               kfree(dev);
                return -ENOMEM;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to