Commit:     3b79cc26708bcc476d4e4bf3846032fa3a1eeb85
Parent:     04cab1329336d4577d6638360c905e360934b425
Author:     Oliver Neukum <[EMAIL PROTECTED]>
AuthorDate: Thu Aug 16 16:06:06 2007 +0200
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Wed Aug 22 14:27:58 2007 -0700

    USB: unkill cxacru atm driver
    it seems like you overdid it a bit in your quest to clean up the
    use of urb->status. In this driver you read it the first thing, which
    means that you are in a race against URB completion you'll
    usually lose, returning -EINPROGRESS. This kills the driver.
    Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
 drivers/usb/atm/cxacru.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index 02c52f8..a73e714 100644
--- a/drivers/usb/atm/cxacru.c
+++ b/drivers/usb/atm/cxacru.c
@@ -456,7 +456,6 @@ static int cxacru_start_wait_urb(struct urb *urb, struct 
completion *done,
                                 int* actual_length)
        struct timer_list timer;
-       int status = urb->status;
        timer.expires = jiffies + msecs_to_jiffies(CMD_TIMEOUT);
@@ -468,7 +467,7 @@ static int cxacru_start_wait_urb(struct urb *urb, struct 
completion *done,
        if (actual_length)
                *actual_length = urb->actual_length;
-       return status;
+       return urb->status; /* must read status after completion */
 static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to