Commit:     db7f3ded8d42c60b0d0a4f71d621e105790b872b
Parent:     d4ac2477fad0f2680e84ec12e387ce67682c5c13
Author:     Jesper Juhl <[EMAIL PROTECTED]>
AuthorDate: Sat Aug 4 20:30:58 2007 +0200
Committer:  Dave Airlie <[EMAIL PROTECTED]>
CommitDate: Mon Aug 6 07:30:20 2007 +1000

    efficeon-agp leaks 'struct agp_bridge_data' in error paths of 
    (This is a resend of a patch originally submitted on 24-Jul-2007 00:14)
    Ok, this is something the coverity checker found (CID: 1813).
    I'm not at all intimate with this code, so I'm not sure if this
    attempt at a fix is correct (but at least it compiles).
    Please look it over and NACK if bad or merge if good ;-)
    Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
    Signed-off-by: Dave Airlie <[EMAIL PROTECTED]>
 drivers/char/agp/efficeon-agp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
index df8da72..d78cd09 100644
--- a/drivers/char/agp/efficeon-agp.c
+++ b/drivers/char/agp/efficeon-agp.c
@@ -375,6 +375,7 @@ static int __devinit agp_efficeon_probe(struct pci_dev 
        if (!r->start && r->end) {
                if (pci_assign_resource(pdev, 0)) {
                        printk(KERN_ERR PFX "could not assign resource 0\n");
+                       agp_put_bridge(bridge);
                        return -ENODEV;
@@ -386,6 +387,7 @@ static int __devinit agp_efficeon_probe(struct pci_dev 
        if (pci_enable_device(pdev)) {
                printk(KERN_ERR PFX "Unable to Enable PCI device\n");
+               agp_put_bridge(bridge);
                return -ENODEV;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to