Commit:     ada83daab31c3ec35845785482124373a62f430c
Parent:     62ee68e3bcb0d056aae5b36dea0388ca25572cdf
Author:     Andre Detsch <[EMAIL PROTECTED]>
AuthorDate: Tue Aug 21 10:06:22 2007 +0800
Committer:  Paul Mackerras <[EMAIL PROTECTED]>
CommitDate: Thu Aug 30 16:27:18 2007 +1000

    [POWERPC] spufs: Don't call spu_run_init from spu_reacquire_runnable
    This fixes a major bug which was happening when a SPU thread advances
    its execution right after being restored to a SPU.  A potentially
    outdated NPC value was being (re)written to the SPU.
    So, spu_run_init, in this case, was either not doing anything relevant,
    or breaking the execution of the SPU thread.
    This fixes a common problem of losing a mailbox write when it was done
    to a saved context.
    Signed-off-by: Andre Detsch <[EMAIL PROTECTED]>
    Signed-off-by: Jeremy Kerr <[EMAIL PROTECTED]>
    Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]>
 arch/powerpc/platforms/cell/spufs/run.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/platforms/cell/spufs/run.c 
index 6abdd8f..958f10e 100644
--- a/arch/powerpc/platforms/cell/spufs/run.c
+++ b/arch/powerpc/platforms/cell/spufs/run.c
@@ -193,11 +193,7 @@ static int spu_reacquire_runnable(struct spu_context *ctx, 
u32 *npc,
        if (ret)
                return ret;
-       ret = spu_run_init(ctx, npc);
-       if (ret) {
-               spu_release(ctx);
-               return ret;
-       }
+       spuctx_switch_state(ctx, SPU_UTIL_USER);
        return 0;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to