Commit:     5d540fb71552b9f2c542bea967200c48be2d8ef6
Parent:     4ccdb4c8727c9963c7aa0d6301df283cf1f8a731
Author:     Christoph Lameter <[EMAIL PROTECTED]>
AuthorDate: Thu Aug 30 23:56:26 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Aug 31 01:42:22 2007 -0700

    slub: do not fail if we cannot register a slab with sysfs
    Do not BUG() if we cannot register a slab with sysfs.  Just print an error.
     The only consequence of not registering is that the slab cache is not
    visible via /sys/slab.  A BUG() may not be visible that early during boot
    and we have had multiple issues here already.
    Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
    Acked-by: David S. Miller <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 mm/slub.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 04151da..7defe84 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3813,7 +3813,9 @@ static int __init slab_sysfs_init(void)
        list_for_each_entry(s, &slab_caches, list) {
                err = sysfs_slab_add(s);
-               BUG_ON(err);
+               if (err)
+                       printk(KERN_ERR "SLUB: Unable to add boot slab %s"
+                                               " to sysfs\n", s->name);
        while (alias_list) {
@@ -3821,7 +3823,9 @@ static int __init slab_sysfs_init(void)
                alias_list = alias_list->next;
                err = sysfs_slab_alias(al->s, al->name);
-               BUG_ON(err);
+               if (err)
+                       printk(KERN_ERR "SLUB: Unable to add boot slab alias"
+                                       " %s to sysfs\n", s->name);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to