Commit:     596e41509550447b030f7b16adaeb0138ab585a8
Parent:     ef8aef55ce61fd0e2af798695f7386ac756ae1e7
Author:     Stephen Hemminger <[EMAIL PROTECTED]>
AuthorDate: Tue Sep 11 10:41:04 2007 +0200
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Tue Sep 11 10:41:04 2007 +0200

    [IPV4] devinet: show all addresses assigned to interface
    Not all ips are shown by "ip addr show" command when IPs number assigned to 
    interface is more than 60-80 (in fact it depends on broadcast/label etc
    presence on each address).
    Steps to reproduce:
    It's terribly simple to reproduce:
    # for i in $(seq 1 100); do ip ad add 10.0.$i.1/24 dev eth10 ; done
    # ip addr show
    this will _not_ show all IPs.
    Looks like the problem is in netlink/ipv4 message processing.
    This is fix from bug submitter, it looks correct.
    Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/ipv4/devinet.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 5b77bda..5dbe580 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1193,7 +1193,7 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct 
netlink_callback *cb)
                for (ifa = in_dev->ifa_list, ip_idx = 0; ifa;
                     ifa = ifa->ifa_next, ip_idx++) {
                        if (ip_idx < s_ip_idx)
-                               goto cont;
+                               continue;
                        if (inet_fill_ifaddr(skb, ifa, NETLINK_CB(cb->skb).pid,
                                             RTM_NEWADDR, NLM_F_MULTI) <= 0)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to