Commit:     7a1fa065a0264f6b3d3003ba5635289f6583c478
Parent:     2123a09f3f129f4d56f59026ec63e5990f86db2f
Author:     Neil Brown <[EMAIL PROTECTED]>
AuthorDate: Fri Sep 14 10:28:08 2007 -0400
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Sep 14 13:58:11 2007 -0700

    Correctly close old nfsd/lockd sockets.
    Commit aaf68cfbf2241d24d46583423f6bff5c47e088b3 added a bias
    to sk_inuse, so this test for an unused socket now fails.  So no
    sockets get closed because they are old (they might get closed
    if the client closed them).
    This bug has existed since 2.6.21-rc1.
    Thanks to Wolfgang Walter for finding and reporting the bug.
    Cc: Wolfgang Walter <[EMAIL PROTECTED]>
    Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
    Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 net/sunrpc/svcsock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 12ff5da..1a89992 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -1592,7 +1592,7 @@ svc_age_temp_sockets(unsigned long closure)
                if (!test_and_set_bit(SK_OLD, &svsk->sk_flags))
-               if (atomic_read(&svsk->sk_inuse) || test_bit(SK_BUSY, 
+               if (atomic_read(&svsk->sk_inuse) > 1 || test_bit(SK_BUSY, 
                list_move(le, &to_be_aged);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to