Commit:     d9f30ec0b0d129b9cbf2b041a6a3159aa24592f6
Parent:     2a38b775b77f99308a4e571c13d908df78ac5e57
Author:     Al Viro <[EMAIL PROTECTED]>
AuthorDate: Sun Sep 16 16:43:04 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Sun Sep 16 16:43:04 2007 -0700

    [VLAN]: Fix net_device leak.
    In "[VLAN]: Move device registation to seperate function" (commit
    e89fe42cd03c8fd3686df82d8390a235717a66de), a pile of code got moved
    to register_vlan_dev(), including grabbing a reference to underlying
    device.  However, original dev_hold() had been left behind, so we
    leak a reference to net_device now...
    Signed-off-by: Al Viro <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/8021q/vlan.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 1583c5e..2a54691 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -562,8 +562,6 @@ static int register_vlan_device(struct net_device *real_dev,
        if (err < 0)
                goto out_free_newdev;
-       /* Account for reference in struct vlan_dev_info */
-       dev_hold(real_dev);
 #ifdef VLAN_DEBUG
        printk(VLAN_DBG "Allocated new device successfully, returning.\n");
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to