Commit:     9db619e66503494e41159de3c76fafabe80d016b
Parent:     f685ddaf0fc9b9f53eb9346c858664776becf5d9
Author:     Wolfgang Walter <[EMAIL PROTECTED]>
AuthorDate: Thu Sep 20 15:51:46 2007 -0400
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Thu Sep 20 13:15:57 2007 -0700

    rpc: fix garbage in printk in svc_tcp_accept()
    we upgraded the kernel of a nfs-server from to Since
    then we get the message
    lockd: too many open TCP sockets, consider increasing the number of nfsd 
    lockd: last TCP connect from ^\\236^\É^D
    These random characters in the second line are caused by a bug in
    (Note: there are two previous __svc_print_addr(sin, buf, sizeof(buf))
    calls in this function, either of which would initialize buf correctly;
    but both are inside "if"'s and are not necessarily executed.  This is
    less obvious in the second case, which is inside a dprintk(), which is a
    macro which expands to an if statement.)
    Signed-off-by: Wolfgang Walter <[EMAIL PROTECTED]>
    Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 net/sunrpc/svcsock.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 1a89992..036ab52 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -1110,7 +1110,8 @@ svc_tcp_accept(struct svc_sock *svsk)
                                       "%s: last TCP connect from %s\n",
-                                      serv->sv_name, buf);
+                                      serv->sv_name, __svc_print_addr(sin,
+                                                       buf, sizeof(buf)));
                         * Always select the oldest socket. It's not fair,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to