Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=56e71efe44eb06ae1761f43cca70a5f3cc54c0fb
Commit:     56e71efe44eb06ae1761f43cca70a5f3cc54c0fb
Parent:     2df3b71b2746469b5b344cf7da5facecd4110cc9
Author:     Feng Tang <[EMAIL PROTECTED]>
AuthorDate: Sat Sep 29 14:15:05 2007 +0800
Committer:  Pierre Ossman <[EMAIL PROTECTED]>
CommitDate: Wed Oct 3 18:40:26 2007 +0200

    sdhci: remove DMA capability check from controller's PCI Class reg
    
    Many host controllers don't fully follow the PCI spec to claim
    whether they support DMA in PCI class register. Leave the driver
    to judge it from the Capability register, quirks and module parameter
    
    Signed-off-by: Feng Tang <[EMAIL PROTECTED]>
    Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]>
---
 drivers/mmc/host/sdhci.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 317578d..866528c 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1299,13 +1299,18 @@ static int __devinit sdhci_probe_slot(struct pci_dev 
*pdev, int slot)
                host->flags |= SDHCI_USE_DMA;
        } else if (chip->quirks & SDHCI_QUIRK_FORCE_DMA)
                host->flags |= SDHCI_USE_DMA;
-       else if ((pdev->class & 0x0000FF) != PCI_SDHCI_IFDMA)
-               DBG("Controller doesn't have DMA interface\n");
        else if (!(caps & SDHCI_CAN_DO_DMA))
                DBG("Controller doesn't have DMA capability\n");
        else
                host->flags |= SDHCI_USE_DMA;
 
+       if (((pdev->class & 0x0000FF) != PCI_SDHCI_IFDMA) &&
+               (host->flags & SDHCI_USE_DMA)) {
+               printk(KERN_WARNING "%s: Will use DMA "
+                       "mode even though HW doesn't fully "
+                       "claim to support it.\n", host->slot_descr);
+       }
+
        if (host->flags & SDHCI_USE_DMA) {
                if (pci_set_dma_mask(pdev, DMA_32BIT_MASK)) {
                        printk(KERN_WARNING "%s: No suitable DMA available. "
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to