Commit:     19453bc18848e842a9743fcc40707e6fb19ae92b
Parent:     5a5b3b5d4fe3acdd9fb73162023422a9ee0e56f3
Author:     Trent Piepho <[EMAIL PROTECTED]>
AuthorDate: Sat Aug 18 22:54:49 2007 -0300
Committer:  Mauro Carvalho Chehab <[EMAIL PROTECTED]>
CommitDate: Tue Oct 9 22:06:00 2007 -0300

    V4L/DVB (6068): cx88-alsa: Use pci_dev->revision
    The revision is part of the pci_dev struct, so there is no need to read it 
    Stop storing the revision and latency in the chip struct, since they're 
    used after being printed out when the driver loads.
    linux/pci.h wasn't included.  It was getting picked up something else,
    probably cx88.h, but this file uses struct pci_dev so it should include 
    Signed-off-by: Trent Piepho <[EMAIL PROTECTED]>
    Signed-off-by: Mauro Carvalho Chehab <[EMAIL PROTECTED]>
 drivers/media/video/cx88/cx88-alsa.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/video/cx88/cx88-alsa.c 
index 3e293da..8d19d33 100644
--- a/drivers/media/video/cx88/cx88-alsa.c
+++ b/drivers/media/video/cx88/cx88-alsa.c
@@ -28,6 +28,7 @@
 #include <linux/device.h>
 #include <linux/interrupt.h>
 #include <linux/dma-mapping.h>
+#include <linux/pci.h>
 #include <asm/delay.h>
 #include <sound/driver.h>
@@ -60,7 +61,6 @@ struct cx88_audio_dev {
        /* pci i/o */
        struct pci_dev             *pci;
-       unsigned char              pci_rev,pci_lat;
        /* audio controls */
        int                        irq;
@@ -667,6 +667,7 @@ static int __devinit snd_cx88_create(struct snd_card *card,
        snd_cx88_card_t   *chip;
        struct cx88_core  *core;
        int               err;
+       unsigned char     pci_lat;
        *rchip = NULL;
@@ -711,13 +712,12 @@ static int __devinit snd_cx88_create(struct snd_card 
        /* print pci info */
-       pci_read_config_byte(pci, PCI_CLASS_REVISION, &chip->pci_rev);
-       pci_read_config_byte(pci, PCI_LATENCY_TIMER,  &chip->pci_lat);
+       pci_read_config_byte(pci, PCI_LATENCY_TIMER, &pci_lat);
        dprintk(1,"ALSA %s/%i: found at %s, rev: %d, irq: %d, "
               "latency: %d, mmio: 0x%llx\n", core->name, devno,
-              pci_name(pci), chip->pci_rev, pci->irq,
-              chip->pci_lat,(unsigned long long)pci_resource_start(pci,0));
+              pci_name(pci), pci->revision, pci->irq,
+              pci_lat, (unsigned long long)pci_resource_start(pci,0));
        chip->irq = pci->irq;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to