Commit:     1f8f4559f8c5829348a010a9e0bbb423310060d1
Parent:     13f7b8c011cd8d16ad3063409b9d969466c9e2f4
Author:     Micah Gruber <[EMAIL PROTECTED]>
AuthorDate: Fri Sep 28 22:42:11 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Wed Oct 10 16:53:53 2007 -0700

    Fix a potential NULL pointer dereference in uli526x_interrupt() in 
    This patch fixes an apparent potential null dereference bug where we
    dereference dev before a null check.  This patch simply remvoes the
    can't-happen test for a null pointer.
    Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
    Cc: Grant Grundler <[EMAIL PROTECTED]>
    Acked-by: Jeff Garzik <[EMAIL PROTECTED]>
    Acked-by: Kyle McMartin <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
 drivers/net/tulip/uli526x.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
index e64bde4..76e5561 100644
--- a/drivers/net/tulip/uli526x.c
+++ b/drivers/net/tulip/uli526x.c
@@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(int irq, void *dev_id)
        unsigned long ioaddr = dev->base_addr;
        unsigned long flags;
-       if (!dev) {
-               ULI526X_DBUG(1, "uli526x_interrupt() without DEVICE arg", 0);
-               return IRQ_NONE;
-       }
        spin_lock_irqsave(&db->lock, flags);
        outl(0, ioaddr + DCR7);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to