Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=720a650f8ab3166d32fc5da64961e8d2158b9452
Commit:     720a650f8ab3166d32fc5da64961e8d2158b9452
Parent:     f19f5111c94053ba4931892f5c01c806de33942e
Author:     Herbert Xu <[EMAIL PROTECTED]>
AuthorDate: Fri Sep 28 09:06:11 2007 +0800
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Wed Oct 10 16:55:45 2007 -0700

    [CRYPTO] cryptomgr: Fix parsing of recursive algorithms
    
    As Joy Latten points out, inner algorithm parameters will miss the closing
    bracket which will also cause the outer algorithm to terminate prematurely.
    
    This patch fixes that also kills the WARN_ON if the number of parameters
    exceed the maximum as that is a user error.
    
    Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
 crypto/cryptomgr.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/crypto/cryptomgr.c b/crypto/cryptomgr.c
index c83884f..e5e3cf8 100644
--- a/crypto/cryptomgr.c
+++ b/crypto/cryptomgr.c
@@ -129,6 +129,7 @@ static int cryptomgr_schedule_probe(struct crypto_larval 
*larval)
                        }
 
                        notnum = 1;
+                       p++;
                }
 
                len = p - name;
@@ -151,7 +152,7 @@ static int cryptomgr_schedule_probe(struct crypto_larval 
*larval)
                param->tb[i + 1] = &param->attrs[i].attr;
                i++;
 
-               if (WARN_ON(i >= CRYPTO_MAX_ATTRS))
+               if (i >= CRYPTO_MAX_ATTRS)
                        goto err_free_param;
 
                if (*p == ')')
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to