Commit:     4dc7b4b0405fd7320940849b6e31ea8ea68fd0df
Parent:     a05afe9146f7611d40a58be34ee8442727a6af1f
Author:     David Gibson <[EMAIL PROTECTED]>
AuthorDate: Tue Aug 14 13:52:42 2007 +1000
Committer:  Paul Mackerras <[EMAIL PROTECTED]>
CommitDate: Fri Aug 17 11:02:05 2007 +1000

    [POWERPC] Fix setting of irq trigger type in UIC driver
    The UIC (interrupt controller in 4xx embedded CPUs) driver currently
    missets the IRQ_lEVEL flag in desc->status, due to a thinko.  This
    patch fixes the bug.
    Currently this is only a cosmetic problem (affects the output in
    /proc/interrupts), however subsequent patches will use the IRQ_LEVEL
    flag to affect flow handling.
    Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]>
    Signed-off-by: David Gibson <[EMAIL PROTECTED]>
    Acked-by: Josh Boyer <[EMAIL PROTECTED]>
    Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]>
 arch/powerpc/sysdev/uic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/sysdev/uic.c b/arch/powerpc/sysdev/uic.c
index 8905989..ef8eb5b 100644
--- a/arch/powerpc/sysdev/uic.c
+++ b/arch/powerpc/sysdev/uic.c
@@ -142,7 +142,7 @@ static int uic_set_irq_type(unsigned int virq, unsigned int 
        desc->status &= ~(IRQ_TYPE_SENSE_MASK | IRQ_LEVEL);
        desc->status |= flow_type & IRQ_TYPE_SENSE_MASK;
-       if (trigger)
+       if (!trigger)
                desc->status |= IRQ_LEVEL;
        spin_unlock_irqrestore(&uic->lock, flags);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to