Commit:     9a5ad13856cbd10be429f09517c51277c02530f7
Parent:     382e6e256b0cb1a84a45a520cef75d1b8ff44663
Author:     Benjamin Marzinski <[EMAIL PROTECTED]>
AuthorDate: Fri Aug 17 20:22:07 2007 -0500
Committer:  Steven Whitehouse <[EMAIL PROTECTED]>
CommitDate: Wed Oct 10 08:55:34 2007 +0100

    [GFS2] Add NULL entry to token table
    match_token() was returning garbage data instead of a fail value. This data
    happened to match a valid option id for an option that required an argument 
    this case, lockproto=%s) For match_token() to correctly fail if the option
    doesn't match any of the tokens, the token table must end with a NULL entry.
    This patch adds the NULL entry.
    Signed-off-by: Benjamin E. Marzinski <[EMAIL PROTECTED]>
    Signed-off-by: Steven Whitehouse <[EMAIL PROTECTED]>
 fs/gfs2/mount.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/fs/gfs2/mount.c b/fs/gfs2/mount.c
index 4864659..b941f9f 100644
--- a/fs/gfs2/mount.c
+++ b/fs/gfs2/mount.c
@@ -42,6 +42,7 @@ enum {
+       Opt_err,
 static match_table_t tokens = {
@@ -64,7 +65,8 @@ static match_table_t tokens = {
        {Opt_suiddir, "suiddir"},
        {Opt_nosuiddir, "nosuiddir"},
        {Opt_data_writeback, "data=writeback"},
-       {Opt_data_ordered, "data=ordered"}
+       {Opt_data_ordered, "data=ordered"},
+       {Opt_err, NULL}
@@ -237,6 +239,7 @@ int gfs2_mount_args(struct gfs2_sbd *sdp, char *data_arg, 
int remount)
                case Opt_data_ordered:
                        args->ar_data = GFS2_DATA_ORDERED;
+               case Opt_err:
                        fs_info(sdp, "unknown option: %s\n", o);
                        error = -EINVAL;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to