Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e6d42f0e962390e956545aa282efb05a9d6a41d1
Commit:     e6d42f0e962390e956545aa282efb05a9d6a41d1
Parent:     5adceac5da3d353dd1318d0482cab94a79472adf
Author:     Satyam Sharma <[EMAIL PROTECTED]>
AuthorDate: Mon Sep 3 01:37:31 2007 +0530
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Fri Oct 12 14:55:25 2007 -0700

    USB: sisusbvga: Fix bug
    
    drivers/usb/misc/sisusbvga/sisusb.c: In function sisusb_open
    drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: sisusb is used 
uninitialized in this function
    
    is a genuine bug (which will cause oops). We cannot use "sisusb" in
    error path for (!interface), because sisusb will itself be derived
    from "interface" later.
    
    Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
 drivers/usb/misc/sisusbvga/sisusb.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/misc/sisusbvga/sisusb.c 
b/drivers/usb/misc/sisusbvga/sisusb.c
index 4d6b893..033bdfe 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -2440,10 +2440,8 @@ sisusb_open(struct inode *inode, struct file *file)
        struct usb_interface *interface;
        int subminor = iminor(inode);
 
-       if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
-               dev_err(&sisusb->sisusb_dev->dev, "Failed to find interface\n");
+       if (!(interface = usb_find_interface(&sisusb_driver, subminor)))
                return -ENODEV;
-       }
 
        if (!(sisusb = usb_get_intfdata(interface)))
                return -ENODEV;
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to