Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9dcfbd97a695a3c28a867501127fa35ac49bc805
Commit:     9dcfbd97a695a3c28a867501127fa35ac49bc805
Parent:     ca0677a29bddee35918bf3c0c55cc3badd69079e
Author:     Andrew Morton <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 2 14:40:46 2007 -0700
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Fri Oct 12 14:55:29 2007 -0700

    USB: fix gregkh-usb-usb-sisusb2vga-convert-printk-to-dev_-macros
    
    drivers/usb/misc/sisusbvga/sisusb.c: In function 'sisusb_open':
    drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: 'sisusb' is used 
uninitialized in this function
    
    I can tell that'll oops just by looking at it.
    
    How come this code assume a 7,000 column xterm? :(
    
    Cc: Felipe Balbi <[EMAIL PROTECTED]>
    Cc: Thomas <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
 drivers/usb/misc/sisusbvga/sisusb.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/misc/sisusbvga/sisusb.c 
b/drivers/usb/misc/sisusbvga/sisusb.c
index 033bdfe..0790829 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -3323,15 +3323,7 @@ static int __init usb_sisusb_init(void)
        sisusb_init_concode();
 #endif
 
-       if (!(retval = usb_register(&sisusb_driver))) {
-
-               dev_info(&sisusb->sisusb_dev->dev, "Driver version %d.%d.%d\n", 
SISUSB_VERSION,
-                               SISUSB_REVISION, SISUSB_PATCHLEVEL);
-               dev_info(&sisusb->sisusb_dev->dev, "sisusb: Copyright (C) 2005 
Thomas Winischhofer\n");
-
-       }
-
-       return retval;
+       return usb_register(&sisusb_driver);
 }
 
 static void __exit usb_sisusb_exit(void)
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to