Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1f5a3d0f34fd5719081c6b8f3dbbcbe328d4da31
Commit:     1f5a3d0f34fd5719081c6b8f3dbbcbe328d4da31
Parent:     ed6e52829c113ca18f042ac55cc77b1b90745eab
Author:     Alan Stern <[EMAIL PROTECTED]>
AuthorDate: Wed Aug 22 13:06:53 2007 -0400
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Fri Oct 12 14:55:19 2007 -0700

    USB: fix mistake in usb_hcd_giveback_urb
    
    This patch (as971) fixes a small mistake: The URB's completion status
    needs to be adjusted before the URB is passed to usmon_urb_complete(),
    not afterward.
    
    Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
 drivers/usb/core/hcd.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index ec17fc4..8b17bab 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1266,9 +1266,6 @@ int usb_hcd_unlink_urb (struct urb *urb, int status)
  */
 void usb_hcd_giveback_urb (struct usb_hcd *hcd, struct urb *urb)
 {
-       unmap_urb_for_dma(hcd, urb);
-       usbmon_urb_complete (&hcd->self, urb);
-       usb_unanchor_urb(urb);
        urb->hcpriv = NULL;
        if (unlikely(urb->unlinked))
                urb->status = urb->unlinked;
@@ -1277,6 +1274,10 @@ void usb_hcd_giveback_urb (struct usb_hcd *hcd, struct 
urb *urb)
                        !urb->status))
                urb->status = -EREMOTEIO;
 
+       unmap_urb_for_dma(hcd, urb);
+       usbmon_urb_complete(&hcd->self, urb);
+       usb_unanchor_urb(urb);
+
        /* pass ownership to the completion handler */
        urb->complete (urb);
        atomic_dec (&urb->use_count);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to