Commit:     10f4b89a0f0586a67f57efb2f5d12fffbb371490
Parent:     427d0bd4fde60f40e9518817d826e48c05262a98
Author:     Masatake YAMATO <[EMAIL PROTECTED]>
AuthorDate: Wed Sep 19 22:59:16 2007 +0900
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Fri Oct 12 14:49:11 2007 -0400

    [SCSI] Fix signness of parameters in scsi module
    In scsi module I've found some inconsistency between variable type
    used in module_param_named and type passed to module_param_named as an
    argument. Especially the inconsistency of `max_scsi_luns' parameter is
    a bit serious because the description text says "last scsi LUN (should
    be between 1 and 2^32-1)".
    Signed-off-by: Masatake YAMATO <[EMAIL PROTECTED]>
    Acked-by: Randy Dunlap <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
 drivers/scsi/scsi_scan.c         |    6 +++---
 drivers/scsi/scsi_transport_fc.c |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 309b224..20df7fe 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -85,7 +85,7 @@ static unsigned int max_scsi_luns = MAX_SCSI_LUNS;
 static unsigned int max_scsi_luns = 1;
-module_param_named(max_luns, max_scsi_luns, int, S_IRUGO|S_IWUSR);
+module_param_named(max_luns, max_scsi_luns, uint, S_IRUGO|S_IWUSR);
                 "last scsi LUN (should be between 1 and 2^32-1)");
@@ -109,14 +109,14 @@ MODULE_PARM_DESC(scan, "sync, async or none");
 static unsigned int max_scsi_report_luns = 511;
-module_param_named(max_report_luns, max_scsi_report_luns, int, 
+module_param_named(max_report_luns, max_scsi_report_luns, uint, 
                 "REPORT LUNS maximum number of LUNS received (should be"
                 " between 1 and 16384)");
 static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ+3;
-module_param_named(inq_timeout, scsi_inq_timeout, int, S_IRUGO|S_IWUSR);
+module_param_named(inq_timeout, scsi_inq_timeout, uint, S_IRUGO|S_IWUSR);
                 "Timeout (in seconds) waiting for devices to answer INQUIRY."
                 " Default is 5. Some non-compliant devices need more.");
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 8df0f08..7a7cfe5 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -474,7 +474,7 @@ static DECLARE_TRANSPORT_CLASS(fc_vport_class,
 static unsigned int fc_dev_loss_tmo = 60;              /* seconds */
-module_param_named(dev_loss_tmo, fc_dev_loss_tmo, int, S_IRUGO|S_IWUSR);
+module_param_named(dev_loss_tmo, fc_dev_loss_tmo, uint, S_IRUGO|S_IWUSR);
                 "Maximum number of seconds that the FC transport should"
                 " insulate the loss of a remote port. Once this value is"
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to