Commit:     c131993b4cbfb6d564619e609b3d0b471ec52c5d
Parent:     1bd405734651c9ebd1c872a452614f9fe381c673
Author:     Matthew Wilcox <[EMAIL PROTECTED]>
AuthorDate: Wed Aug 15 12:56:59 2007 -0600
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Fri Oct 12 14:51:26 2007 -0400

    [SCSI] qlogicfas: Close narrow race in release
    We were releasing the IRQ before removing the host, so commands could
    still be coming in which would never be seen by the interrupt handler.
    Just remove the host before releasing the IRQ to close this race.
    Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
 drivers/scsi/qlogicfas.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qlogicfas.c b/drivers/scsi/qlogicfas.c
index 94baca8..1e874f1 100644
--- a/drivers/scsi/qlogicfas.c
+++ b/drivers/scsi/qlogicfas.c
@@ -166,6 +166,7 @@ static int qlogicfas_release(struct Scsi_Host *shost)
        struct qlogicfas408_priv *priv = get_priv_by_host(shost);
+       scsi_remove_host(shost);
        if (shost->irq) {
                free_irq(shost->irq, shost);
@@ -174,7 +175,6 @@ static int qlogicfas_release(struct Scsi_Host *shost)
        if (shost->io_port && shost->n_io_port)
                release_region(shost->io_port, shost->n_io_port);
-       scsi_remove_host(shost);
        return 0;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to