Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=41cb8ac025dbbf6782eae10d231e7e2336ad3724
Commit:     41cb8ac025dbbf6782eae10d231e7e2336ad3724
Parent:     902aaed0d983dfd459fcb2b678608d4584782200
Author:     Nick Piggin <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 16 01:24:53 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Tue Oct 16 09:42:54 2007 -0700

    mm: revert KERNEL_DS buffered write optimisation
    
    Revert the patch from Neil Brown to optimise NFSD writev handling.
    
    Cc: Neil Brown <[EMAIL PROTECTED]>
    Signed-off-by: Nick Piggin <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 mm/filemap.c |   32 +++++++++++++-------------------
 1 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 7989c44..c504db1 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1874,27 +1874,21 @@ generic_file_buffered_write(struct kiocb *iocb, const 
struct iovec *iov,
                /* Limit the size of the copy to the caller's write size */
                bytes = min(bytes, count);
 
-               /* We only need to worry about prefaulting when writes are from
-                * user-space.  NFSd uses vfs_writev with several non-aligned
-                * segments in the vector, and limiting to one segment a time is
-                * a noticeable performance for re-write
+               /*
+                * Limit the size of the copy to that of the current segment,
+                * because fault_in_pages_readable() doesn't know how to walk
+                * segments.
                 */
-               if (!segment_eq(get_fs(), KERNEL_DS)) {
-                       /*
-                        * Limit the size of the copy to that of the current
-                        * segment, because fault_in_pages_readable() doesn't
-                        * know how to walk segments.
-                        */
-                       bytes = min(bytes, cur_iov->iov_len - iov_base);
+               bytes = min(bytes, cur_iov->iov_len - iov_base);
+
+               /*
+                * Bring in the user page that we will copy from _first_.
+                * Otherwise there's a nasty deadlock on copying from the
+                * same page as we're writing to, without it being marked
+                * up-to-date.
+                */
+               fault_in_pages_readable(buf, bytes);
 
-                       /*
-                        * Bring in the user page that we will copy from
-                        * _first_.  Otherwise there's a nasty deadlock on
-                        * copying from the same page as we're writing to,
-                        * without it being marked up-to-date.
-                        */
-                       fault_in_pages_readable(buf, bytes);
-               }
                page = __grab_cache_page(mapping,index,&cached_page,&lru_pvec);
                if (!page) {
                        status = -ENOMEM;
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to