Commit:     e8a285b7b10029c3da7e9bbaa1659e7e08178912
Parent:     b1b2e7cf4a9742f61d76fcb419b1fd13159876a5
Author:     Jesper Juhl <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 16 01:27:52 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Tue Oct 16 09:43:10 2007 -0700

    isdn: guard against a potential NULL pointer dereference in 
    In drivers/isdn/capi/kcapi.c::old_capi_manufacturer(), if the call to
    get_capi_ctr_by_nr(ldef.contr); in line 823 returns NULL, then we'll be
    dereferencing a NULL pointer in the very next line.
    (Found by Coverity checker as bug #402)
    Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
    Acked-by: Karsten Keil <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/isdn/capi/kcapi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c
index 9f73bc2..f555318 100644
--- a/drivers/isdn/capi/kcapi.c
+++ b/drivers/isdn/capi/kcapi.c
@@ -821,6 +821,8 @@ static int old_capi_manufacturer(unsigned int cmd, void 
__user *data)
                                return -EFAULT;
                card = get_capi_ctr_by_nr(ldef.contr);
+               if (!card)
+                       return -EINVAL;
                card = capi_ctr_get(card);
                if (!card)
                        return -ESRCH;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to