Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6ed44ad3ebec52059f6f534deeb08f1d701852c5
Commit:     6ed44ad3ebec52059f6f534deeb08f1d701852c5
Parent:     12f288bffeaa3196ebd5da49c5c7ac06c6188b61
Author:     Jesper Juhl <[EMAIL PROTECTED]>
AuthorDate: Mon Aug 6 14:05:27 2007 +0200
Committer:  Jaroslav Kysela <[EMAIL PROTECTED]>
CommitDate: Tue Oct 16 15:58:25 2007 +0200

    [ALSA] au88x0: mem leak fix in snd_vortex_create()
    
    In sound/pci/au88x0/au88x0.c::snd_vortex_create() :
    The Coverity checker found that if we allocate storage for 'chip'
    but then leave via the  regions_out:  label, then we end up leaking
    the storage allocated for 'chip'.
    I believe simply freeing 'chip' before the 'return err;' line is
    all we need to fix this, but please double-check me :)
    
    Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
    Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]>
    Signed-off-by: Jaroslav Kysela <[EMAIL PROTECTED]>
---
 sound/pci/au88x0/au88x0.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
index 5ec1b6f..f70286a 100644
--- a/sound/pci/au88x0/au88x0.c
+++ b/sound/pci/au88x0/au88x0.c
@@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev 
*pci, vortex_t ** rchip)
        pci_disable_device(chip->pci_dev);
        //FIXME: this not the right place to unregister the gameport
        vortex_gameport_unregister(chip);
+       kfree(chip);
        return err;
 }
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to