Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=de47062a17a236543690e0c23dfb30cb11c6e674
Commit:     de47062a17a236543690e0c23dfb30cb11c6e674
Parent:     c34114f4acbc89a217148ebe166b2a68f973a7b9
Author:     Jesper Juhl <[EMAIL PROTECTED]>
AuthorDate: Sat Aug 4 20:30:42 2007 +0200
Committer:  Sam Ravnborg <[EMAIL PROTECTED](none)>
CommitDate: Fri Oct 12 21:15:30 2007 +0200

    kbuild: improve scripts/gcc-version.sh output a bit when called without args
    
    Currently, if you call scripts/gcc-version.sh without arguments it will
    generate this output :
    
    $ sh scripts/gcc-version.sh
    scripts/gcc-version.sh: line 12: [: =: unary operator expected
    scripts/gcc-version.sh: line 16: -E: command not found
    scripts/gcc-version.sh: line 17: -E: command not found
    0000
    
    Not too pretty. I believe this is an improvement :
    
    $ sh scripts/gcc-version.sh
    Error: No compiler specified.
    Usage:
            scripts/gcc-version.sh <gcc-command>
    
    Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
    Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
---
 scripts/gcc-version.sh |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/scripts/gcc-version.sh b/scripts/gcc-version.sh
index 8a1d187..a5121a6 100644
--- a/scripts/gcc-version.sh
+++ b/scripts/gcc-version.sh
@@ -9,10 +9,16 @@
 # gcc-2.95.3, `030301' for gcc-3.3.1, etc.
 #
 
-if [ $1 = "-p" ] ; then with_patchlevel=1; shift; fi
+if [[ $1 = "-p" ]] ; then with_patchlevel=1; shift; fi
 
 compiler="$*"
 
+if [ ${#compiler} -eq 0 ]; then
+       echo "Error: No compiler specified."
+       echo -e "Usage:\n\t$0 <gcc-command>"
+       exit 1
+fi
+
 MAJOR=$(echo __GNUC__ | $compiler -E -xc - | tail -n 1)
 MINOR=$(echo __GNUC_MINOR__ | $compiler -E -xc - | tail -n 1)
 if [ "x$with_patchlevel" != "x" ] ; then
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to