Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0c53c8e6eb456cde30f2305421c605713856abc8
Commit:     0c53c8e6eb456cde30f2305421c605713856abc8
Parent:     a0f97e06a43cf524e616f09e6af3398e1e9c1c5b
Author:     Sam Ravnborg <[EMAIL PROTECTED](none)>
AuthorDate: Sun Oct 14 22:26:53 2007 +0200
Committer:  Sam Ravnborg <[EMAIL PROTECTED](none)>
CommitDate: Sun Oct 14 22:26:53 2007 +0200

    kbuild: check for wrong use of CFLAGS
    
    External modules have in a few cases modifed gcc option
    by modifying CFLAGS. This has never been documented and
    was a bad practice.
    With the check to use KBUILD_CFLAGS it will no longer work
    so we better error out and tell what was wrong as a service
    to the external module users.
    
    This check can be overruled if
    KBUILD_NOPEDANTIC is set to something.
    Addid this possibility may allow older external
    module to build without any code modifications but potentially
    only loosing some un-important gcc options.
    
    Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
---
 scripts/Makefile.build |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 8ef1d61..d32b400 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -28,10 +28,20 @@ EXTRA_LDFLAGS  :=
 
 include scripts/Kbuild.include
 
+# For backward compatibility check that these variables does not change
+save-cflags := $(CFLAGS)
+
 # The filename Kbuild has precedence over Makefile
 kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src))
-include $(if $(wildcard $(kbuild-dir)/Kbuild), $(kbuild-dir)/Kbuild, 
$(kbuild-dir)/Makefile)
-
+kbuild-file := $(if $(wildcard 
$(kbuild-dir)/Kbuild),$(kbuild-dir)/Kbuild,$(kbuild-dir)/Makefile)
+include $(kbuild-file)
+
+# If the save-* variables changed error out
+ifeq ($(KBUILD_NOPEDANTIC),)
+        ifneq ("$(save-cflags)","$(CFLAGS)")
+                $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use 
EXTRA_CFLAGS)
+        endif
+endif
 include scripts/Makefile.lib
 
 ifdef host-progs
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to