Commit:     69e2b602966533256edce1ed1b24fec23fe05962
Parent:     261b5f664c6c68c5209656a71c41823eda0d938b
Author:     Satyam Sharma <[EMAIL PROTECTED]>
AuthorDate: Wed Aug 15 20:05:38 2007 +0530
Committer:  Stefan Richter <[EMAIL PROTECTED]>
CommitDate: Tue Oct 16 23:59:56 2007 +0200

    ieee1394: Fix kthread stopping in nodemgr_host_thread
    The nodemgr host thread can exit on its own even when kthread_should_stop
    is not true, on receiving a signal (might never happen in practice, as
    it ignores signals). But considering kthread_stop() must not be mixed with
    kthreads that can exit on their own, I think changing the code like this
    is clearer. This change means the thread can cut its sleep short when
    receive a signal but looking at the code around, that sounds okay (and
    again, it might never actually recieve a signal in practice).
    Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
    Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
 drivers/ieee1394/nodemgr.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c
index 1939fee..11712a3 100644
--- a/drivers/ieee1394/nodemgr.c
+++ b/drivers/ieee1394/nodemgr.c
@@ -1712,7 +1712,8 @@ static int nodemgr_host_thread(void *__hi)
                 * to make sure things settle down. */
                g = get_hpsb_generation(host);
                for (i = 0; i < 4 ; i++) {
-                       if (msleep_interruptible(63) || kthread_should_stop())
+                       msleep_interruptible(63);
+                       if (kthread_should_stop())
                                goto exit;
                        /* Now get the generation in which the node ID's we 
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to