Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d2c9740b499f959ed513375b6e35c2ab161921cb
Commit:     d2c9740b499f959ed513375b6e35c2ab161921cb
Parent:     04fc8bbcf5eb25fa2aec290b302a9878dde20168
Author:     Denis Cheng <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 16 23:26:14 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Wed Oct 17 08:42:47 2007 -0700

    nbd: use list_for_each_entry_safe to make it more consolidated and readable
    
    Thus the traverse of the loop may delete nodes, use the safe version.
    
    Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
    Cc: Paul Clements <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 drivers/block/nbd.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index be5ec3a..d7a4215 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -233,8 +233,7 @@ error_out:
 
 static struct request *nbd_find_request(struct nbd_device *lo, char *handle)
 {
-       struct request *req;
-       struct list_head *tmp;
+       struct request *req, *tmp;
        struct request *xreq;
        int err;
 
@@ -245,8 +244,7 @@ static struct request *nbd_find_request(struct nbd_device 
*lo, char *handle)
                goto out;
 
        spin_lock(&lo->queue_lock);
-       list_for_each(tmp, &lo->queue_head) {
-               req = list_entry(tmp, struct request, queuelist);
+       list_for_each_entry_safe(req, tmp, &lo->queue_head, queuelist) {
                if (req != xreq)
                        continue;
                list_del_init(&req->queuelist);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to