Commit:     55ca3e796d452d1fd213846ae6ce8bc4d37b54cc
Parent:     0cbc591bf884a5662b2fbb21b5c09fa1c1c7b579
Author:     WANG Cong <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 16 23:26:15 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Wed Oct 17 08:42:47 2007 -0700

    fs/romfs/inode.c: trivial improvements
    - There are no lists in fs/romfs/inode.c, so using list_entry
      is a bit confusing.  Replace it with container_of.
    - It is unnecessary to cast the return value of
      kmem_cache_alloc, since it returns a void* pointer.
    Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 fs/romfs/inode.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c
index 7c5e5f5..a49cf5b 100644
--- a/fs/romfs/inode.c
+++ b/fs/romfs/inode.c
@@ -92,7 +92,7 @@ static inline unsigned long romfs_maxsize(struct super_block 
 static inline struct romfs_inode_info *ROMFS_I(struct inode *inode)
-       return list_entry(inode, struct romfs_inode_info, vfs_inode);
+       return container_of(inode, struct romfs_inode_info, vfs_inode);
 static __u32
@@ -555,7 +555,7 @@ static struct kmem_cache * romfs_inode_cachep;
 static struct inode *romfs_alloc_inode(struct super_block *sb)
        struct romfs_inode_info *ei;
-       ei = (struct romfs_inode_info *)kmem_cache_alloc(romfs_inode_cachep, 
+       ei = kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL);
        if (!ei)
                return NULL;
        return &ei->vfs_inode;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to