Commit:     827afdf093cce59bbbf9dc9f1c2eab86e2232b9e
Parent:     cba4fbbff2e9722e93b28e18fa7714b9013cbdda
Author:     Adrian Bunk <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 16 23:29:25 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Wed Oct 17 08:42:55 2007 -0700

    n_hdlc.c: fix check-after-use
    The Coverity checker spotted that we'd have already oops'ed if "tty"
    was NULL.
    Since "tty" can't be NULL when we reach this line of code this patch
    removes the NULL check.
    Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
    Acked-by: Alan Cox <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/char/n_hdlc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/n_hdlc.c b/drivers/char/n_hdlc.c
index e8332f3..82bcfb9 100644
--- a/drivers/char/n_hdlc.c
+++ b/drivers/char/n_hdlc.c
@@ -229,7 +229,7 @@ static void n_hdlc_release(struct n_hdlc *n_hdlc)
        wake_up_interruptible (&tty->read_wait);
        wake_up_interruptible (&tty->write_wait);
-       if (tty != NULL && tty->disc_data == n_hdlc)
+       if (tty->disc_data == n_hdlc)
                tty->disc_data = NULL;  /* Break the tty->n_hdlc link */
        /* Release transmit and receive buffers */
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to