Commit:     2b12ab6d33f413aabb623197eeecaad5c216e6ae
Parent:     8299d7f7c067a30a67ad359d416128c4ff57dcd1
Author:     NeilBrown <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 16 23:30:53 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Wed Oct 17 08:43:03 2007 -0700

    md: 'sync_action' in sysfs returns wrong value for readonly arrays
    When an array is started read-only, MD_RECOVERY_NEEDED can be set but no
    recovery will be running.  This causes 'sync_action' to report the wrong
    We could remove the test for MD_RECOVERY_NEEDED, but doing so would leave a
    small gap after requesting a sync action, where 'sync_action' would still
    report the old value.
    So make sure that for a read-only array, 'sync_action' always returns 
    Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/md/md.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index f173ace..510625e 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -2714,7 +2714,7 @@ action_show(mddev_t *mddev, char *page)
        char *type = "idle";
        if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) ||
-           test_bit(MD_RECOVERY_NEEDED, &mddev->recovery)) {
+           (!mddev->ro && test_bit(MD_RECOVERY_NEEDED, &mddev->recovery))) {
                if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
                        type = "reshape";
                else if (test_bit(MD_RECOVERY_SYNC, &mddev->recovery)) {
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to