Commit:     4b21960f90d4d011e49e386d0525b1e89f320658
Parent:     37ab7a269637086d56940c31968f3fb3389b6d68
Author:     Trent Piepho <[EMAIL PROTECTED]>
AuthorDate: Thu Oct 11 16:40:10 2007 -0700
Committer:  Sam Ravnborg <[EMAIL PROTECTED](none)>
CommitDate: Thu Oct 18 13:35:49 2007 +0200

    kbuild: modpost problem when symbols move from one module to another
    When part of build an external module tree, modpost first reads in the
    kernel's and then the external tree's Module.symvers files.  From these 
    it establishes a symbol => module mapping.  When it later reads in each 
    built and processes the symbols it finds, it discovers the symbol=>module
    mapping from Module.symvers and leaves it as it is.
    The problem comes with a module has been re-named or a symbol has moved from
    one module to another, since the Module.symvers file was generated.  modpost
    does not update the symbol=>module mapping when it finds the new location of
    the symbol when scanning the newly built modules.  This results in the 
    containing incorrect dependency information and the new Module.symvers file
    written by modpost will also contain the incorrect mappings, perpetuating 
    problem to the next build, and so on.
    When building the out of kernel development tree for kernel subsystem, like
    v4l-dvb or ALSA, deleting the external Module.symvers file before building
    (which the kernel build system doesn't do and shouldn't be necessary 
    won't fix the problem.  modpost still reads the kernel's Module.symvers, and
    since we a building a kernel subsystem, it will define the same symbols as 
    external modules.
    Signed-off-by: Trent Piepho <[EMAIL PROTECTED]>
    Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
 scripts/mod/modpost.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 2ef9a19..93ac52a 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -268,6 +268,9 @@ static struct symbol *sym_add_exported(const char *name, 
struct module *mod,
                             "was in %s%s\n", mod->name, name,
                             is_vmlinux(s->module->name) ?"":".ko");
+               } else {
+                       /* In case Modules.symvers was out of date */
+                       s->module = mod;
        s->preloaded = 0;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to