Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c310f099be953a20b5fabed341ad085f444cf2bd
Commit:     c310f099be953a20b5fabed341ad085f444cf2bd
Parent:     bd5435e76a226b7151ae5aaee2cd366ab003dd2e
Author:     Ryan Reading <[EMAIL PROTECTED]>
AuthorDate: Wed Oct 17 19:34:11 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Wed Oct 17 19:34:11 2007 -0700

    [IRDA]: IrCOMM discovery indication simplification
    
    From: Ryan Reading <[EMAIL PROTECTED]>
    
    Every IrCOMM socket is registered with the discovery subsystem, so we don't
    need to loop over all of them for every discovery event. We just need to
    do it for the registered IrCOMM socket.
    
    Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
---
 net/irda/ircomm/ircomm_tty_attach.c |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/net/irda/ircomm/ircomm_tty_attach.c 
b/net/irda/ircomm/ircomm_tty_attach.c
index 824309d..b5a1388 100644
--- a/net/irda/ircomm/ircomm_tty_attach.c
+++ b/net/irda/ircomm/ircomm_tty_attach.c
@@ -381,18 +381,9 @@ static void ircomm_tty_discovery_indication(discinfo_t 
*discovery,
        info.daddr = discovery->daddr;
        info.saddr = discovery->saddr;
 
-       /* FIXME. We have a locking problem on the hashbin here.
-        * We probably need to use hashbin_find_next(), but we first
-        * need to ensure that "line" is unique. - Jean II */
-       self = (struct ircomm_tty_cb *) hashbin_get_first(ircomm_tty);
-       while (self != NULL) {
-               IRDA_ASSERT(self->magic == IRCOMM_TTY_MAGIC, return;);
-
-               ircomm_tty_do_event(self, IRCOMM_TTY_DISCOVERY_INDICATION,
-                                   NULL, &info);
-
-               self = (struct ircomm_tty_cb *) hashbin_get_next(ircomm_tty);
-       }
+       self = (struct ircomm_tty_cb *) priv;
+       ircomm_tty_do_event(self, IRCOMM_TTY_DISCOVERY_INDICATION,
+                           NULL, &info);
 }
 
 /*
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to