Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=26f0324922e50e0ef7677aaf96287b862c2fec61
Commit:     26f0324922e50e0ef7677aaf96287b862c2fec61
Parent:     19c4d5664aaf9419dfe6b24990a93305fded6403
Author:     Kyle McMartin <[EMAIL PROTECTED]>
AuthorDate: Thu Oct 18 00:04:06 2007 -0700
Committer:  Kyle McMartin <[EMAIL PROTECTED]>
CommitDate: Thu Oct 18 01:07:50 2007 -0700

    [PARISC] Quiet sysfs_create_link __must_check warnings in pdc_stable
    
    Failing to create the links doesn't seem like a fatal error in these
    paths. WARN_ON seems better than nothing though.
    
    Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]>
---
 drivers/parisc/pdc_stable.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
index fc4bde2..ebb09e9 100644
--- a/drivers/parisc/pdc_stable.c
+++ b/drivers/parisc/pdc_stable.c
@@ -282,6 +282,7 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, const 
char *buf, size_t coun
        unsigned short i;
        char in[count+1], *temp;
        struct device *dev;
+       int ret;
 
        if (!entry || !buf || !count)
                return -EINVAL;
@@ -333,7 +334,9 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, const 
char *buf, size_t coun
        
        /* Update the symlink to the real device */
        sysfs_remove_link(&entry->kobj, "device");
-       sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
+       ret = sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
+       WARN_ON(ret);
+
        write_unlock(&entry->rw_lock);
        
        printk(KERN_INFO PDCS_PREFIX ": changed \"%s\" path to \"%s\"\n",
@@ -1003,8 +1006,10 @@ pdcs_register_pathentries(void)
                entry->ready = 2;
                
                /* Add a nice symlink to the real device */
-               if (entry->dev)
-                       sysfs_create_link(&entry->kobj, &entry->dev->kobj, 
"device");
+               if (entry->dev) {
+                       err = sysfs_create_link(&entry->kobj, 
&entry->dev->kobj, "device");
+                       WARN_ON(err);
+               }
 
                write_unlock(&entry->rw_lock);
        }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to