Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=150981b0306fc5773b929e31ab5b0590c87cc77c
Commit:     150981b0306fc5773b929e31ab5b0590c87cc77c
Parent:     2dcb407e61458ded17503d6bd12b8c064965368b
Author:     Alan Cox <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 23 16:50:02 2007 +0100
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Tue Oct 23 21:20:02 2007 -0400

    libata-core: auditting chk_status v check_status
    
    Did a complete audit of these and found we have another error case.
    
    ata_bus_softreset calls ata_check_status which means that it tries to do
    an ioread8 on the port blindly and check versus 0xFF for an error.
    
    It should of course be using the ap->ops method for this via chk_status,
    and this bug causes a wrog status call on the NS87415 at least.
    
    Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
 drivers/ata/libata-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b458639..0978b2f 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3267,7 +3267,7 @@ static int ata_bus_softreset(struct ata_port *ap, 
unsigned int devmask,
         * the bus shows 0xFF because the odd clown forgets the D7
         * pulldown resistor.
         */
-       if (ata_check_status(ap) == 0xFF)
+       if (ata_chk_status(ap) == 0xFF)
                return -ENODEV;
 
        return ata_bus_post_reset(ap, devmask, deadline);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to