Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8999e04f3b7930f0c6f091a541237de51d8dd372
Commit:     8999e04f3b7930f0c6f091a541237de51d8dd372
Parent:     dda6b022f3222f09d3fb49f5dfabd31d33e0d10b
Author:     Latchesar Ionkov <[EMAIL PROTECTED]>
AuthorDate: Tue Nov 6 08:02:53 2007 -0600
Committer:  Eric Van Hensbergen <[EMAIL PROTECTED]>
CommitDate: Tue Nov 6 08:02:53 2007 -0600

    9p: use copy of the options value instead of original
    
    v9fs_parse_options function uses strsep which modifies the value of the
    v9ses->options field. That modified value is later passed to the function
    that creates the transport potentially making the transport creation
    function to fail.
    
    This patch creates a copy of v9ses->option field that v9fs_parse_options
    function uses instead of the original value.
    
    Signed-off-by: Latchesar Ionkov <[EMAIL PROTECTED]>
    Acked-by: Eric Van Hensbergen <[EMAIL PROTECTED]>
---
 fs/9p/v9fs.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index 756f7e9..fbb12da 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -82,7 +82,7 @@ static match_table_t tokens = {
 
 static void v9fs_parse_options(struct v9fs_session_info *v9ses)
 {
-       char *options = v9ses->options;
+       char *options;
        substring_t args[MAX_OPT_ARGS];
        char *p;
        int option;
@@ -96,9 +96,10 @@ static void v9fs_parse_options(struct v9fs_session_info 
*v9ses)
        v9ses->cache = 0;
        v9ses->trans = v9fs_default_trans();
 
-       if (!options)
+       if (!v9ses->options)
                return;
 
+       options = kstrdup(v9ses->options, GFP_KERNEL);
        while ((p = strsep(&options, ",")) != NULL) {
                int token;
                if (!*p)
@@ -169,6 +170,7 @@ static void v9fs_parse_options(struct v9fs_session_info 
*v9ses)
                        continue;
                }
        }
+       kfree(options);
 }
 
 /**
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to