Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d2ea732e9ecb68841206f2761ae91360da87cfac
Commit:     d2ea732e9ecb68841206f2761ae91360da87cfac
Parent:     cacd40e07c5ad7068221b3910098f1d364e74e45
Author:     Evgeniy Dushistov <[EMAIL PROTECTED]>
AuthorDate: Sun Nov 4 23:22:29 2007 +0300
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Mon Nov 5 17:57:30 2007 -0500

    82596: free nonexistent resource fix
    
    During booting of last vanilla kernel I got:
    Trying to free nonexistent resource...
    
    This because of if "ENABLE_APRICOT" is on we do:
    request_region(ioaddr,...)
    if (checksum test failed)
      goto out1;
    dev->base_addr = ioaddr;//<-here mistake
    
    out1:
    release_region(dev->base_addr,...)
    
    This change fixes this bug for me.
    
    Signed-off-by: Evgeniy Dushistov <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
 drivers/net/82596.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/82596.c b/drivers/net/82596.c
index bb30d5b..2797da7 100644
--- a/drivers/net/82596.c
+++ b/drivers/net/82596.c
@@ -1192,6 +1192,8 @@ struct net_device * __init i82596_probe(int unit)
                        goto out;
                }
 
+               dev->base_addr = ioaddr;
+
                for (i = 0; i < 8; i++) {
                        eth_addr[i] = inb(ioaddr + 8 + i);
                        checksum += eth_addr[i];
@@ -1209,7 +1211,6 @@ struct net_device * __init i82596_probe(int unit)
                        goto out1;
                }
 
-               dev->base_addr = ioaddr;
                dev->irq = 10;
        }
 #endif
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to