Commit:     9f70968af3e6e21612e06e153aa71c62dee5a09b
Parent:     019d1b2247c6898589560c6f3b3e7ec280b0010a
Author:     Mark Fasheh <[EMAIL PROTECTED]>
AuthorDate: Thu Oct 18 12:36:10 2007 -0700
Committer:  Mark Fasheh <[EMAIL PROTECTED]>
CommitDate: Tue Nov 6 15:31:52 2007 -0800

    ocfs2: Re-order iput in ocfs2_drop_dentry_lock
    Do this to avoid a theoretical (I haven't seen this in practice) race where
    the downconvert thread might drop the dentry lock, allowing a remote unlink
    to proceed before dropping the inode locks. This could bounce access to the
    orphan dir between nodes.
    There doesn't seem to be a need to do the same in ocfs2_dentry_iput() as
    that's never called for the last ref drop from the downconvert thread.
    Signed-off-by: Mark Fasheh <[EMAIL PROTECTED]>
 fs/ocfs2/dcache.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ocfs2/dcache.c b/fs/ocfs2/dcache.c
index 3094ddb..1957a5e 100644
--- a/fs/ocfs2/dcache.c
+++ b/fs/ocfs2/dcache.c
@@ -318,9 +318,9 @@ out_attach:
 static void ocfs2_drop_dentry_lock(struct ocfs2_super *osb,
                                   struct ocfs2_dentry_lock *dl)
+       iput(dl->dl_inode);
        ocfs2_simple_drop_lockres(osb, &dl->dl_lockres);
-       iput(dl->dl_inode);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to