Commit:     8cd8fa557f439f23baef2158b271667d0c579482
Parent:     d4d5d205b653fe68c898d42e7a27a7363a4fb3ba
Author:     Jeff Dike <[EMAIL PROTECTED]>
AuthorDate: Wed Nov 14 16:58:53 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Wed Nov 14 18:45:37 2007 -0800

    uml: update address space affected by pud_clear
    pud_clear wasn't setting the _PAGE_NEWPAGE bit, fooling tlb_flush into
    thinking that this area of the address space was up-to-date and not 
    whatever was covered by the pud.
    This manifested itself as ldconfig on x86_64 complaining about the first
    library it looked at not being a valid ELF file.  A config file is mapped at
    0x4000000, as the only thing mapped under its pud, and unmapped.  The
    unmapping caused a pud_clear, which, due to this bug, didn't actually unmap
    the config file data on the host.  The first library is then mapped at the
    same location, but is not actually mapped on the host because accesses to it
    cause no page faults.  As a result, ldconfig sees the old config file data.
    [EMAIL PROTECTED]: coding-style cleanups]
    Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 include/asm-um/pgtable-3level.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-um/pgtable-3level.h b/include/asm-um/pgtable-3level.h
index aa82b88..3ebafba 100644
--- a/include/asm-um/pgtable-3level.h
+++ b/include/asm-um/pgtable-3level.h
@@ -71,7 +71,7 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, 
unsigned long address)
 static inline void pud_clear (pud_t *pud)
-        set_pud(pud, __pud(0));
+       set_pud(pud, __pud(_PAGE_NEWPAGE));
 #define pud_page(pud) phys_to_page(pud_val(pud) & PAGE_MASK)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to