Commit:     cb51f973bce7aef46452b0c6faea8f791885f5b8
Parent:     22800a2830ec07e7cc5c837999890ac47cc7f5de
Author:     Arjan van de Ven <[EMAIL PROTECTED]>
AuthorDate: Wed Nov 14 17:00:10 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Wed Nov 14 18:45:42 2007 -0800

    mark sys_open/sys_read exports unused
    sys_open / sys_read were used in the early 1.2 days to load firmware from
    disk inside drivers.  Since 2.0 or so this was deprecated behavior, but
    several drivers still were using this.  Since a few years we have a
    request_firmware() API that implements this in a nice, consistent way.
    Only some old ISA sound drivers (pre-ALSA) still straggled along for some
    time....  however with commit c2b1239a9f22f19c53543b460b24507d0e21ea0c the
    last user is now gone.
    This is a good thing, since using sys_open / sys_read etc for firmware is a
    very buggy to dangerous thing to do; these operations put an fd in the
    process file descriptor table....  which then can be tampered with from
    other threads for example.  For those who don't want the firmware loader,
    filp_open()/vfs_read are the better APIs to use, without this security
    The patch below marks sys_open and sys_read unused now that they're
    really not used anymore, and for deletion in the 2.6.25 timeframe.
    Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 fs/open.c       |    2 +-
 fs/read_write.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/open.c b/fs/open.c
index 3b69c53..4932b4d 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -1061,7 +1061,7 @@ asmlinkage long sys_open(const char __user *filename, int 
flags, int mode)
        return ret;
+EXPORT_UNUSED_SYMBOL_GPL(sys_open); /* To be deleted for 2.6.25 */
 asmlinkage long sys_openat(int dfd, const char __user *filename, int flags,
                           int mode)
diff --git a/fs/read_write.c b/fs/read_write.c
index 124693e..ea1f94c 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -370,7 +370,7 @@ asmlinkage ssize_t sys_read(unsigned int fd, char __user * 
buf, size_t count)
        return ret;
+EXPORT_UNUSED_SYMBOL_GPL(sys_read); /* to be deleted for 2.6.25 */
 asmlinkage ssize_t sys_write(unsigned int fd, const char __user * buf, size_t 
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to